Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random password for CommunicateAsNewUser PBA #1434

Merged
merged 3 commits into from
Aug 30, 2021

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Aug 30, 2021

Merge this before #1433 to avoid messy merge conflicts!


What does this PR do?

#1410

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running the PBA on Windows

  • If applicable, add screenshots or log transcripts of the feature working
    image

@shreyamalviya shreyamalviya changed the title agent: Use random password for CommunicateAsNewUser PBA Use random password for CommunicateAsNewUser PBA Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #1434 (deb037c) into develop (54f80df) will increase coverage by 0.22%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1434      +/-   ##
===========================================
+ Coverage    40.06%   40.29%   +0.22%     
===========================================
  Files          465      465              
  Lines        13835    13836       +1     
===========================================
+ Hits          5543     5575      +32     
+ Misses        8292     8261      -31     
Impacted Files Coverage Δ
...key/post_breach/actions/communicate_as_new_user.py 66.66% <33.33%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f80df...deb037c. Read the comment docs.

@shreyamalviya shreyamalviya mentioned this pull request Aug 30, 2021
7 tasks
@mssalvatore mssalvatore merged commit 02bd3ef into develop Aug 30, 2021
@mssalvatore mssalvatore deleted the pba-use-random-pwd branch August 30, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants