Ransomware skip encrypt readme #1333
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1333 +/- ##
===========================================
+ Coverage 40.25% 40.31% +0.06%
===========================================
Files 474 475 +1
Lines 13860 13874 +14
===========================================
+ Hits 5579 5593 +14
Misses 8281 8281
Continue to review full report at Codecov.
|
mssalvatore
requested review from
shreyamalviya and
VakarisZ
and removed request for
shreyamalviya
| if filepath.name != README_FILE_NAME: | ||
| return True | ||
|
|
||
| return get_file_sha256_hash(filepath) != README_SHA256_HASH |
There was a problem hiding this comment.
So it turns out that even on windows, the readme.txt dropped retains the unix line endings, good to know
There was a problem hiding this comment.
Yeah. I even opened the file in notepad, added a space, and saved it and the line endings were not changed. This will likely vary from editor to editor.
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def stable_file(data_for_tests_dir) -> Path: |
There was a problem hiding this comment.
We should add a typehint that data_for_tests_dir is a Path as well. If we pass something else, the syntax of some_path / "some_file.txt" will break
There was a problem hiding this comment.
data_for_tests_dir isn't actually a Path in this case, it's a pytest fixture. There are type hints for fixtures, but you have to import them from a file that's intended to be private. pytest-dev/pytest#5981 (comment)
| @@ -53,3 +55,12 @@ def test_directories_not_selected(ransomware_test_data, file_selector): | |||
| selected_files = file_selector(ransomware_test_data) | |||
|
|
|||
| assert (ransomware_test_data / SUBDIR / HELLO_TXT) not in selected_files | |||
|
|
|||
|
|
|||
| def test_ransomware_readme_not_selected(ransomware_target, file_selector): | |||
There was a problem hiding this comment.
Shouldn't we add a test where README.txt get's selected if contents are different?
mssalvatore
force-pushed
the
ransomware-skip-encrypt-readme
branch
from
b45cf6c to
52412ab
Compare
What does this PR do?
Fixes #1304
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
If applicable, add screenshots or log transcripts of the feature working