-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API endpoint for ransomware report #1297
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1297 +/- ##
===========================================
- Coverage 30.68% 30.66% -0.02%
===========================================
Files 449 450 +1
Lines 13467 13475 +8
===========================================
Hits 4132 4132
- Misses 9335 9343 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should get a changelog entry, since it's changing Monkey Island's API.
class RansomwareReport(flask_restful.Resource): | ||
@jwt_required | ||
def get(self): | ||
return jsonify({"show": True, "report": None}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The back end should not be making decisions about what the front end should show. It's the backend's job to report what data it has. It's the frontend's job to decide how to display that data.
What does this PR do?
#1240
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?If applicable, add screenshots or log transcripts of the feature working