Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API endpoint for ransomware report #1297

Merged
merged 3 commits into from
Jul 6, 2021

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

#1240

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Ran Island and added a log statement in ReportPage.js to make sure it worked.

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #1297 (c78c955) into develop (01b9c41) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1297      +/-   ##
===========================================
- Coverage    30.68%   30.66%   -0.02%     
===========================================
  Files          449      450       +1     
  Lines        13467    13475       +8     
===========================================
  Hits          4132     4132              
- Misses        9335     9343       +8     
Impacted Files Coverage Δ
monkey/monkey_island/cc/app.py 0.00% <0.00%> (ø)
...ey/monkey_island/cc/resources/ransomware_report.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b9c41...c78c955. Read the comment docs.

Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should get a changelog entry, since it's changing Monkey Island's API.

class RansomwareReport(flask_restful.Resource):
@jwt_required
def get(self):
return jsonify({"show": True, "report": None})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The back end should not be making decisions about what the front end should show. It's the backend's job to report what data it has. It's the frontend's job to decide how to display that data.

@mssalvatore mssalvatore mentioned this pull request Jul 5, 2021
7 tasks
@mssalvatore mssalvatore merged commit 0fd88b8 into develop Jul 6, 2021
@shreyamalviya shreyamalviya deleted the ransomware-report-API-endpoint branch August 2, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants