Create secure custom PBA directory on Windows #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1270 +/- ##
===========================================
- Coverage 30.12% 30.11% -0.02%
===========================================
Files 444 445 +1
Lines 13317 13341 +24
===========================================
+ Hits 4012 4017 +5
- Misses 9305 9324 +19
Continue to review full report at Codecov.
|
mssalvatore
requested changes
Jun 28, 2021
| import win32api | ||
| import win32security | ||
|
|
||
| FULL_CONTROL = 2032127 |
There was a problem hiding this comment.
We also use this in test_file_utils.py. Can we put this constant somewhere common for tests? Maybe tests/monkey_island/utils.py.
| st = os.stat(PostBreachFilesService.get_custom_pba_directory()) | ||
|
|
||
| assert st.st_mode == 0o40700 | ||
|
|
||
|
|
||
| def _get_acl_and_sid_from_path(path: str): |
There was a problem hiding this comment.
This is also duplicated from test_file_utils.py.
mssalvatore
reviewed
Jun 28, 2021
monkey/tests/unit_tests/monkey_island/cc/services/test_post_breach_files.py
Show resolved
Hide resolved
mssalvatore
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1196
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
If applicable, add screenshots or log transcripts of the feature working