Remove dead python code reported by Vulture #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using these specific names prevents Vulture from identifying these parameters as unused.
…zero_trust/test_common/monkey_finding_data.py`
…vices/reporting/report.py`
…es/post_breach_files.py`
…by_id()` in `monkey_island/cc/services/node.py`
…/services/attack/attack_report.py`
…s/auth/user_store.py`
…d/cc/models/monkey.py`
…TTP` in `infection_monkey/model/__init__.py`
…breach/post_breach_handler.py`
…)`, and `_traceroute_linux` from `infection_monkey/network/tools.py`
…/post_breach_handler.py`
…et_region()` from `monkey_island/cc/environment/aws.py`
…inTests/ComboFile.py`
…fo/wmi_consts.py`
…`infection_monkey/network/tools.py`
…ion_monkey/network/tools.py`
…/exploit/web_rce.py`
…_COPY_FILENAME_64` in `infection_monkey/exploit/sambacry.py`
…nfection_monkey/example.conf`
…info_collectors_names.py`
…mon/cloud/aws/aws_service.py`
…st_user_creds.py`
mssalvatore
requested changes
May 6, 2021
| @@ -189,97 +158,6 @@ def tcp_port_to_service(port): | |||
| return "tcp-" + str(port) | |||
|
|
|||
|
|
|||
| def traceroute(target_ip, ttl=64): | |||
There was a problem hiding this comment.
@VakarisZ Are we using traceroute anywhere anymore? If not, can we get rid of everything that references the binaries (e.g. deployment scripts and release documentation).
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| class BootloaderHttpServer(ThreadingMixIn, HTTPServer): | |||
| def __init__(self, mongo_url): | |||
| self.mongo_client = pymongo.MongoClient(mongo_url) | |||
| pymongo.MongoClient(mongo_url) | |||
There was a problem hiding this comment.
What does this call achieve if we're not using the object it returns?
Codecov Report
@@ Coverage Diff @@
## develop #1149 +/- ##
===========================================
- Coverage 28.66% 28.62% -0.04%
===========================================
Files 411 411
Lines 12898 12744 -154
===========================================
- Hits 3697 3648 -49
+ Misses 9201 9096 -105
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1123
PR Checklist
Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?If applicable, add screenshots or log transcripts of the feature working