Move UTs to separate directory, add pytest to pre-commit #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some test files were in their own "tests/" directory. Deleted the extra "tests/" directories.
Shift it from monkey/pytest.ini to pyproject.toml. Add conftest.py in tests/ to add monkey directory to sys.path so test files recognize paths.
Codecov Report
@@ Coverage Diff @@
## develop #1109 +/- ##
===========================================
+ Coverage 29.01% 29.13% +0.11%
===========================================
Files 409 410 +1
Lines 12911 12934 +23
===========================================
+ Hits 3746 3768 +22
- Misses 9165 9166 +1
Continue to review full report at Codecov.
|
The pytest documentation states that the testpaths configuration option "Sets list of directories that should be searched ... when executing pytest from the rootdir directory." Since pytest is not executed from the rootdir directory, testpaths has no effect. Appending the "tests/" directory to the end of addopts reduces the time required to run the test suite by approximately 6 seconds.
mssalvatore
requested changes
Apr 19, 2021
(Run `pre-commit install --hook-type pre-push`)
mssalvatore
approved these changes
Apr 20, 2021
shreyamalviya
commented
Apr 21, 2021
shreyamalviya
commented
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1102