Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty fields in configuration #540

Closed
VakarisZ opened this issue Jan 27, 2020 · 5 comments · Fixed by #550
Closed

Empty fields in configuration #540

VakarisZ opened this issue Jan 27, 2020 · 5 comments · Fixed by #550
Assignees
Labels
Beginner friendly New to the project? This issue is good for you! Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island.

Comments

@VakarisZ
Copy link
Contributor

Describe the bug

Configuration allows submission of empty fields, but in monkey they get registered as values of None and might throw errors.
I found the following error, but more fields should be checked.

Config:

image

Monkey log:

image

Expected behaviour

We should test all fields and make sure that empty values either can't be submitter or doesn't end up on configuration.

@VakarisZ VakarisZ added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Island Beginner friendly New to the project? This issue is good for you! labels Jan 27, 2020
@shreyamalviya
Copy link
Contributor

Hi! I'd like to give this issue a shot. How should I get started?

@VakarisZ
Copy link
Contributor Author

Hi. 1. Take a look at our wiki 2. deploy development environment using deployment scripts. 3. Look at monkey island code, especially configuration service.

@VakarisZ VakarisZ assigned VakarisZ and shreyamalviya and unassigned VakarisZ Feb 12, 2020
@shreyamalviya
Copy link
Contributor

Thanks, @VakarisZ. I ran the deployment scripts, but how exactly do I run it and test it?

@VakarisZ
Copy link
Contributor Author

Run mongodb and then island python script. Take a look at scripts in monkey_island/windows or /linux. Scripts there might not be perfect, but they will give you an idea on what to run. You can also install production version, to peek around and see what this project is all about.

@VakarisZ
Copy link
Contributor Author

Also, I've sent you an invite to our slack to the gmail. Join us there to get a better guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner friendly New to the project? This issue is good for you! Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants