-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent IDs are inconsistent #3119
Labels
Bug
An error, flaw, misbehavior or failure in the Monkey or Monkey Island.
Complexity: Medium
Impact: High
Plugins
Milestone
Comments
mssalvatore
added
Bug
An error, flaw, misbehavior or failure in the Monkey or Monkey Island.
Impact: High
Complexity: Medium
Plugins
labels
Mar 16, 2023
This was referenced Mar 28, 2023
mssalvatore
added a commit
that referenced
this issue
Mar 28, 2023
cakekoa
added a commit
that referenced
this issue
Mar 28, 2023
mssalvatore
pushed a commit
that referenced
this issue
Mar 28, 2023
10 tasks
cakekoa
added a commit
that referenced
this issue
Mar 28, 2023
cakekoa
added a commit
that referenced
this issue
Mar 28, 2023
mssalvatore
pushed a commit
that referenced
this issue
Mar 28, 2023
cakekoa
added a commit
that referenced
this issue
Mar 28, 2023
mssalvatore
pushed a commit
that referenced
this issue
Mar 28, 2023
10 tasks
cakekoa
added a commit
that referenced
this issue
Mar 28, 2023
mssalvatore
pushed a commit
that referenced
this issue
Mar 28, 2023
mssalvatore
added a commit
that referenced
this issue
Mar 28, 2023
10 tasks
cakekoa
added a commit
that referenced
this issue
Mar 28, 2023
mssalvatore
pushed a commit
that referenced
this issue
Mar 28, 2023
mssalvatore
added a commit
that referenced
this issue
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
An error, flaw, misbehavior or failure in the Monkey or Monkey Island.
Complexity: Medium
Impact: High
Plugins
Describe the bug
get_agent_id()
is declared to be a global singleton. As a result, when plugins (which are running in different processes) callget_agent_id()
, they do not receive the "cached" value, but instead receive a new value. This means that all agents which are spawned by a plugin exploiter will have the wrong parent ID.To Reproduce
Steps to reproduce the behavior:
Expected behavior
The parent ID sent to child agents should match the ID of parent agents.
Machine version (please complete the following information):
Recommended Solution
The agent ID should be passed from
monkey.py
down to any components that need it.Tasks
Heart.__init__()
Construct plugins (PluginLoader) with the agent IDnot needed, all of this is handled in the plugin registryget_agent_id()
(the caching is no longer necessary) (0.25d) @cakekoaThe text was updated successfully, but these errors were encountered: