Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manual run page #2593

Closed
VakarisZ opened this issue Nov 16, 2022 · 1 comment · Fixed by #3328 or #4130
Closed

Update manual run page #2593

VakarisZ opened this issue Nov 16, 2022 · 1 comment · Fixed by #3328 or #4130
Assignees
@shreyamalviya
Labels
Complexity: Low Impact: Low Refactor Reported by user sp/3
Milestone
v2.2.0

Comments

@VakarisZ
Copy link
Contributor

Refactor

Manual run page is outdated. We now have the ability to provide multiple servers and the current page doesn't document the options well (what is the second dropdown, what does it do? Which should I pick?)
image
@snyk-bot snyk-bot mentioned this issue Nov 20, 2022
Open
@mssalvatore mssalvatore added v2.2.0 and removed v2.2.0 labels Mar 28, 2023
@mssalvatore mssalvatore added this to the v2.2.0 milestone Mar 28, 2023
@shreyamalviya shreyamalviya self-assigned this May 10, 2023
@shreyamalviya shreyamalviya mentioned this issue May 10, 2023
Merged
10 tasks
mssalvatore added a commit that referenced this issue May 10, 2023
@mssalvatore
Changelog: Improve entry for #2593
ec60c40
mssalvatore added a commit that referenced this issue May 10, 2023
@mssalvatore
Merge branch '2593-update-manual-run-page' into develop
774953d 
Issue #2593
PR #3328
@mssalvatore
Copy link
Collaborator

I'm reopening this, as it seems that #2593 did not properly resolve the issue. Note that we also need to make this change for the Run From Island option.

@mssalvatore mssalvatore reopened this Mar 27, 2024
@ilija-lazoroski ilija-lazoroski mentioned this issue Mar 29, 2024
Merged
10 tasks
mssalvatore added a commit that referenced this issue Mar 29, 2024
@mssalvatore
Merge branch '2593-add-servers-to-run-commands' into develop
806dd83 
Issue #2593
PR #4130
mssalvatore added a commit that referenced this issue Mar 29, 2024
@mssalvatore
Project: Replace "Fixes" with "Issue" in PR template
f61ed55 
We ran into a problem with #2593 where it was improperly resolved.
PR #3328 did not fully resolve the issue, but was merged because it made
necessary improvements. However, because the PR template contained
"Fixes #...", when PR #3328 was merged GitHub automatically closed
Issue #2593. This flew under the radar and Issue #2593 was therefore not
properly resolved until 2 releases later.

By changing this template, we hope to avoid similar sequences of events
in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shreyamalviya shreyamalviya

Labels
Complexity: Low Impact: Low Refactor Reported by user sp/3
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

Update manual run page guardicore/monkey
2593 add servers to run commands guardicore/monkey
3 participants
@mssalvatore @VakarisZ @shreyamalviya