Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create stubbed /api/agent-plugins/<string:type>/<string:name> endpoint #2578

Closed
1 task
mssalvatore opened this issue Nov 14, 2022 · 0 comments · Fixed by #2611
Closed
1 task

Create stubbed /api/agent-plugins/<string:type>/<string:name> endpoint #2578

mssalvatore opened this issue Nov 14, 2022 · 0 comments · Fixed by #2611
Assignees
@cakekoa
Labels
Complexity: Low Feature Issue that describes a new feature to be implemented. Impact: High Plugins Refactor

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Nov 14, 2022 •
edited by cakekoa
Loading

Description

Create a stubbed endpoint at /api/agent-plugins/<string:type>/<string:name>. The stubbed endpoint will always return 404.

Goal/Context

Agents will request plugins from the Island at runtime. Between now and when plugins are fully implemented, we can begin to implement the infrastructure for passing them from the Island to the agent. At a later date, this endpoint will be fully implemented to return plugins instead of 404. For now, the stubbed endpoint allows development on the plugin infrastructure (e.g. #2579) to proceed.

Tasks

  • Implement the stubbed endpoint (0.25d) @cakekoa
@mssalvatore mssalvatore added Feature Issue that describes a new feature to be implemented. Impact: High Complexity: Low Refactor labels Nov 14, 2022
@cakekoa cakekoa self-assigned this Nov 21, 2022
@cakekoa cakekoa mentioned this issue Nov 21, 2022
Merged
8 tasks
mssalvatore added a commit that referenced this issue Mar 16, 2023
@mssalvatore
Hadoop: Disable speculative execution in YARN job
98f078b 
Hadoop's speculative execution feature has lead to a number of
difficulties. See #655, #1781, and #2578. Of concern is that the issue
where Hadoop sends a SIGKILL to the first process (#2578) could cause
significant issues when implementing agent OTP authentication (#3077).

Setting max-app-attempts to 1 resolves these issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cakekoa cakekoa

Labels
Complexity: Low Feature Issue that describes a new feature to be implemented. Impact: High Plugins Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2578 stub agent plugins endpoint guardicore/monkey
2 participants
@cakekoa @mssalvatore