Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding different SSH key extensions #1882

Closed
Piesa opened this issue Apr 12, 2022 · 2 comments
Closed

Adding different SSH key extensions #1882

Piesa opened this issue Apr 12, 2022 · 2 comments
Labels
Complexity: Medium Feature Issue that describes a new feature to be implemented. Impact: Medium Plugins
Milestone

Comments

@Piesa
Copy link

Piesa commented Apr 12, 2022

Is your feature request related to a problem? Please describe.
Currently as far as I understand Monkey Agent is searching resident system home directory for SSH keys to steal, looking especially for .pub and after finding one, looking for with corresponding private key.

The problem is that monkey is ignoring the .pem or .ppk also containing private keys.

Additionally, it should in my opinion search for them even if the pubkey won't be there, as often there are only privkeys stored in a location.

Describe the solution you'd like
Monkey Agent should gather also gather other popular key extensions, like .pem, .ppk, or even check the text files that are same name as .pub file.
Also searching for full pair should not be nesscescary.

Describe alternatives you've considered
Leaving it as it is, as it's working with .pub and pair.

Cheers!

@Piesa Piesa added the Feature Issue that describes a new feature to be implemented. label Apr 12, 2022
@Piesa Piesa changed the title Adding different SSH key Adding different SSH key extensions Apr 12, 2022
@mssalvatore
Copy link
Collaborator

When resolving this issue, take a peek at #1509. The SSH collector may be making similar assumptions.

@mssalvatore
Copy link
Collaborator

@Piesa This has been resolved on develop. Let me know if you'd like to test out a development binary. Otherwise, it will be released in the next few weeks with v2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature Issue that describes a new feature to be implemented. Impact: Medium Plugins
Projects
None yet
Development

No branches or pull requests

2 participants