Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "+dev" from version numbers #1553

Closed
3 tasks done
mssalvatore opened this issue Oct 26, 2021 · 1 comment · Fixed by #1920
Closed
3 tasks done

Remove "+dev" from version numbers #1553

mssalvatore opened this issue Oct 26, 2021 · 1 comment · Fixed by #1920
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Medium DevOps Impact: Medium

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Oct 26, 2021 •
edited by ilija-lazoroski
Loading

Release packages are built with +dev in the version. Figure out why and fix it.

Development packages should be versioned like v[VERSION]+[GIT_COMMIT_ID]. Release packages should be versioned like v[VERSION]

Tasks

  • Fix artifact version numbers to be as described above (0.25d) @ilija-lazoroski
    • Fix local builds
    • Fix jenkins builds
@mssalvatore mssalvatore added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. DevOps Impact: Medium Complexity: Medium labels Oct 26, 2021
@shreyamalviya
Copy link
Contributor

Happens because of:
image

@ilija-lazoroski ilija-lazoroski mentioned this issue Apr 28, 2022
Merged
8 tasks
mssalvatore pushed a commit that referenced this issue Apr 29, 2022
@ilija-lazoroski @mssalvatore
Build: Change BUILD file to include commit hash on dev builds
35ab980 
Issue #1553
mssalvatore pushed a commit that referenced this issue Apr 29, 2022
@ilija-lazoroski @mssalvatore
Build: Change BUILD file to include commit hash on dev builds
0a145be 
Issue #1553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Medium DevOps Impact: Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change BUILD file to include commit hash on dev builds guardicore/monkey
2 participants
@mssalvatore @shreyamalviya