Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New installations don't clean the database #1114

Closed
2 tasks
VakarisZ opened this issue Apr 22, 2021 · 0 comments · Fixed by #1530
Closed
2 tasks

New installations don't clean the database #1114

VakarisZ opened this issue Apr 22, 2021 · 0 comments · Fixed by #1530
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: High Expert Issue requires specific knowledge or access to internal resources and is not suitable for beginners Impact: High Release

Comments

@VakarisZ
Copy link
Contributor

VakarisZ commented Apr 22, 2021

Describe the bug

New installations doesn't clean the database, so when users update, the monkey crashes, because of the old database.

To Reproduce

Steps to reproduce the behavior:

  1. Install 1.7
  2. Run monkey
  3. Update to 1.10
  4. Monkey tries to use 1.7 database and crashes

Expected behavior

On installation, database directory should be found and cleaned. Update: the whole data dir should probably be cleaned.

Screenshots

image

Machine version (please complete the following information):

  • OS: Windows or Linux (unknown, likely both)

Tasks

Tasks:

  • Alter MSI installers to remove the default data_dir on uninstall: - @VakarisZ
  • Add the below logic to ensure a smooth upgrade process for AppImage or MSI with custom data_dir - @VakarisZ

Pseudocode

def island_start():
    if data_dir exists:
        if data_dir/version exists and not my_version == data_dir/version:
            rename data_dir
        else if not data_dir/version exists:
            rename data_dir

@VakarisZ VakarisZ added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Release Impact: High Expert Issue requires specific knowledge or access to internal resources and is not suitable for beginners labels Apr 22, 2021
@VakarisZ VakarisZ mentioned this issue Oct 14, 2021
7 tasks
@mssalvatore mssalvatore reopened this Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: High Expert Issue requires specific knowledge or access to internal resources and is not suitable for beginners Impact: High Release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants