Rename Design.GuardianView To Design.Editorial

[JamieB-gu]

Why?

We'd like to rename Design.GuardianView to Design.Editorial.

1. To keep its name consistent with how it's referred to elsewhere.
2. To keep it internally consistent with how other Designs are named (i.e. they're not prefixed with the word Guardian).

Changes

• Rename Design.GuardianView to Design.Editorial

[oliverlloyd]

This makes a lot of sense and will help people understand these designs in future

[paperboyo]

👍 (also: Observer)

[gtrufitt]

they're not prefixed with the word Guardian

GuardianView is 'The Guardian View', right?

But yes 👍

[joecowton1]

Good thinking 👍

[JamieB-gu]

GuardianView is 'The Guardian View', right?

Is there a difference between "The Guardian View" and an "Editorial"?

[gtrufitt]

GuardianView is 'The Guardian View', right?

Is there a difference between "The Guardian View" and an "Editorial"?

Maybe, if as @paperboyo mentions, Observer is included in Editorials

https://www.theguardian.com/profile/editorial

But, that said, current Design Type is pointing at tone/editorials tag that includes Observer https://github.com/guardian/content-api-scala-client/blob/63ca817bb8ad49eb8869603b74ec91247c0c6bfe/client/src/main/scala/com.gu.contentapi.client/utils/CapiModelEnrichment.scala#L46

Carry on!

(Side note: we need to keep the scala CAPI client in sync with the Design Types)

[paperboyo]

Is there a difference between "The Guardian View" and an "Editorial"?

I hope not! 😆