This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
Result #13
Merged
Result #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieB-gu
requested review from
gtrufitt,
alexduf,
SiAdcock,
liywjl,
webb04 and
frankie297
alexduf
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
Same as: #12 (comment)
The code certainly look good, but how does the DCR team feel about that style of programming?
Fair question, see my comment on the other PR for reference. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Added an
Resulttype and companion functions. This PR relies on #12 and is also a clone of the type that we've been using for some time inapps-rendering. I'm migrating it to this repo because I'd like to make use of it inliveblog-renderingas well, and it may be useful for DCR if and when it starts to consumeliveblog-rendering.Changes
Resulttype, consisting ofOkandErrfromUnsafeconstructor to create aResultfrom a possible JavaScript exceptionokanderrconvenience functions to create aResulteither,map,mapError,partitionandandThenfunctions for working withResulttoOptionfunction to convert aResultto anOption