This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
Add observations of mid-deploy scale-out events #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
force-pushed
the
aa/scale-out-mid-deploy
branch
from
699231f
to
d65cfb1
Compare
akash1810
force-pushed
the
aa/scale-out-mid-deploy
branch
from
d65cfb1
to
811b9d7
Compare
jacobwinch
reviewed
Sep 3, 2024
| In this test we deployed [application version](../dist) `ABC` to `500` in the stack | ||
| [`ScalingAsgRollingUpdate`](../packages/cdk/lib/scaling-asg-rolling-update.ts) (CFN stack `playground-CODE-scaling-asg-rolling-update`). | ||
|
|
||
| The aim of this test is to understand the behaviour in the ["Ophan scenario"](https://github.com/guardian/riff-raff/issues/1342). |
There was a problem hiding this comment.
Minor: I don't think this aim is applicable in this scenario?
Suggested change
| The aim of this test is to understand the behaviour in the ["Ophan scenario"](https://github.com/guardian/riff-raff/issues/1342). |
There was a problem hiding this comment.
Hmm, not sure I agree. Any deployment can fail, and we can scale at any time. To me, "Ophan scenario" is "we need to scale during deployment", there's no restriction on if the artifact being deployed is good or bad.
TBH I was tempted to merge the two documents together, but it didn't read very clearly.
jacobwinch
reviewed
Sep 3, 2024
| The aim of this test is to understand the behaviour in the ["Ophan scenario"](https://github.com/guardian/riff-raff/issues/1342). | ||
|
|
||
| ## Highlights | ||
| The deployment leaves the service over-capacity. |
There was a problem hiding this comment.
I guess this is similar to the findings in https://github.com/guardian/testing-asg-rolling-update/blob/main/observations/healthy-to-unhealthy.md#highlights (but at least in this case we know it will eventually scale down automatically!)
jacobwinch
approved these changes
Sep 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Document the behaviour of scale-out events mid-deployment, i.e. the Ophan scenario.