Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sbt to allow Scala Steward to run #539

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

rtyley
Copy link
Member

@rtyley rtyley commented Oct 23, 2024

We need at least sbt 1.9.0 to run Scala Steward, see:

Otherwise the Scala Steward run fails:

2024-10-23 10:41:09,359 ERROR Steward guardian/tagmanager failed
  org.scalasteward.core.io.process$ProcessFailedException: '"SBT_OPTS=-Xmx2048m -Xss8m -XX:MaxMetaspaceSize=512m" sbt -Dsbt.color=false -Dsbt.log.noformat=true -Dsbt.supershell=false -Dsbt.server.forcestart=true ;+ stewardDependencies;reload plugins;stewardDependencies' exited with code 1.
  [info] [launcher] getting org.scala-sbt sbt 1.7.1  (this may take some time)...
  [info] [launcher] getting Scala 2.12.16 (for sbt)...
  [info] welcome to sbt 1.7.1 (Amazon.com Inc. Java 21.0.5)
  error:
    bad constant pool index: 0 at pos: 48454
       while compiling: <no file>
          during phase: globalPhase=<no phase>, enteringPhase=<some phase>
       library version: version 2.12.16
      compiler version: version 2.12.16
    reconstructed args: -classpath /home/runner/.sbt/boot/scala-2.12.16/lib/scala-library.jar -Yrangepos
  
    last tree to typer: EmptyTree
         tree position: <unknown>
              tree tpe: <notype>
                symbol: null
             call site: <none> in <none>

Comment on lines +15 to +18
/*
See https://github.com/guardian/maintaining-scala-projects/issues/13
*/
libraryDependencySchemes += "org.scala-lang.modules" %% "scala-xml" % VersionScheme.Always
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See:

In the future, this line of libraryDependencySchemes config will eventually be able to be removed, probably with:

@rtyley rtyley marked this pull request as ready for review October 23, 2024 10:53
@rtyley rtyley requested a review from JamieB-gu October 23, 2024 10:53
@rtyley rtyley merged commit 3d35558 into main Oct 23, 2024
3 checks passed
@rtyley rtyley deleted the upgrade-sbt-to-allow-running-scala-steward branch October 23, 2024 14:29
@prout-bot
Copy link

Seen on PROD (merged by @rtyley 5 minutes and 19 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants