This repository has been archived by the owner on May 11, 2022. It is now read-only.
update sbt-dependency-graph to allow snyk monitor to work #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexflav23
approved these changes
Oct 11, 2019
|
Seen on PROD (created by @johnduffell and merged by @alexflav23 7 minutes and 30 seconds ago) Please check your changes! Sentry Release: subscriptions, subscriptions-client-side |
|
✅ Testing in PROD passed! Details |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating sbt to 1.3.2, snyk monitor didn't work any more. This causes snyk monitor not to realise the dependencies have changed.
I have bumped it to the latest, but actually there are still outstanding bugs. At least this means this step will pass. See the issue on the plugin: sbt/sbt-dependency-graph#178
@alexflav23 @twrichards