Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify reading from S3 by using transformToString #34

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

kenoir
Copy link
Contributor

@kenoir kenoir commented Oct 31, 2022

What does this change?

Removes the need to deal with byte arrays using sdkStreamMixin.

This makes our code a bit simpler and easier to understand. It also fixes an error in main.

@kenoir kenoir requested review from a team as code owners October 31, 2022 13:14
@kenoir kenoir merged commit 1ae6d8c into main Oct 31, 2022
@kenoir kenoir deleted the rk/sdk-stream-mixin branch October 31, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants