-
Notifications
You must be signed in to change notification settings - Fork 245
update "scribe-common" includes to include "src" #217
update "scribe-common" includes to include "src" #217
Conversation
Added bonus: in 53bf24f I removed the |
I think you missed the paths for the example and the tests: https://github.com/guardian/scribe/blob/master/examples/amd.html#L40 https://github.com/guardian/scribe/blob/master/test/app/index.html#L12 |
@OliverJAsh Ok, updated the tests and example as well. |
Merge conflict! |
This syntax is compatible with CommonJS as well as RequireJS. As described in: http://git.io/CGL0Lg
Now we can remove the `src/api/element.js` file since "scribe-common" offers the exact same helper functions.
@hmgibson23 Rebased. Hopefully we can get this merged before another trivial styling commit creates a new conflict 😉 |
Great - 👍 from me. I'll just wait for @OliverJAsh to take a look and approve. |
@hmgibson23 Would you mind checking this PR out and making sure the tests still run? Travis builds still fail for foreign PRs. |
All tests working in both Chrome and Firefox |
👍 |
1 similar comment
+1 |
update "scribe-common" includes to include "src"
This syntax is compatible with CommonJS as well as RequireJS.
As described in: http://git.io/CGL0Lg