Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Move scribe-common to dependencies; use approx version. #207

Merged
merged 1 commit into from
Jul 1, 2014

Conversation

lrowe
Copy link
Contributor

@lrowe lrowe commented Jun 23, 2014

No description provided.

@samvasko
Copy link
Contributor

Yea, this. Currently scribe is pretty much broken for browserify because those two lines The the correct path should be with src/ otherwise you get a build error. And there is no way to fix it using package.json AFAIK.

  'scribe-common/src/element',
  'scribe-common/src/node'
  1. Move node.js and element.js to root of scribe-common
  2. Change all the references to use src

It is currently breaking deployment

@TooTallNate
Copy link
Contributor

@Bliker See guardian/scribe-common#2.

OliverJAsh pushed a commit that referenced this pull request Jul 1, 2014
Move scribe-common to dependencies; use approx version.
@OliverJAsh OliverJAsh merged commit b91c131 into guardian:master Jul 1, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants