This repository has been archived by the owner on May 9, 2022. It is now read-only.
Fix "scribe-common" dependency #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodash is not used in this plugin.
Matches the `bower.json` file this way.
|
I have still trouble after doing this manually myself. I also had to change And it kinda leaves me puzzled how to actually fix this. |
|
@Bliker See guardian/scribe-common#2 (comment). @TooTallNate Merge conflict! |
|
Ping @TooTallNate |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package on npm does not depend on
scribe-common, however the source code for this plugin attempts to loadscribe-common/element.In addition,
lodash-amdwas declared as a dependency but was not used in this plugin, so removed that as a dependency.A re-publish to npm after this would be much appreciated! 🍻