-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace obsolete 'Generate Token' step, thanks to improved Scala Steward GitHub Action support #46
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,9 @@ on: | |
app_id: | ||
required: true | ||
type: string | ||
app_installation_id: | ||
required: true | ||
type: string | ||
secrets: | ||
private_key: | ||
required: true | ||
|
@@ -22,19 +25,13 @@ jobs: | |
with: | ||
repository: guardian/scala-steward-public-repos | ||
path: common-config | ||
- name: Generate token | ||
id: generate-token | ||
uses: tibdex/github-app-token@v1 | ||
with: | ||
app_id: ${{ inputs.app_id }} | ||
private_key: ${{ secrets.private_key }} | ||
|
||
- name: Execute Scala Steward | ||
uses: scala-steward-org/[email protected] | ||
|
||
with: | ||
# Use the token generated by the previous step and the | ||
# Guardian Scala Steward GitHub App | ||
github-token: ${{ steps.generate-token.outputs.token }} | ||
repos-file: REPOSITORIES.md | ||
github-app-id: ${{ inputs.app_id }} | ||
github-app-installation-id: ${{ inputs.app_installation_id }} | ||
github-app-key: ${{ secrets.private_key }} | ||
repos-file: REPOSITORIES.md # possibly no longer necessary, thanks to `github-app-*` configuration | ||
repo-config: common-config/scala-steward.conf # from checkout of guardian/scala-steward-public-repos |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,36 +1,12 @@ | ||
# Our Scala Steward GitHub Action will run on any repo that our GitHub App is granted access to. | ||
# | ||
# You only need to add your repo to *this* file if you're specifying a non-default branch to update. | ||
# Thanks to https://github.com/guardian/scala-steward-public-repos/pull/40 this is probably no longer necessary! | ||
|
||
- guardian/amiable:dependency-updates_1 | ||
- guardian/amigo:dependency-updates | ||
- guardian/amiup | ||
- guardian/apps-rendering-api-models | ||
- guardian/discussion-avatar | ||
- guardian/google-search-indexing-observatory | ||
- guardian/grid-feeds | ||
- guardian/gu-who | ||
- guardian/identity-processes | ||
- guardian/invoicing-api | ||
- guardian/janus-app:dependency-updates | ||
- guardian/manage-help-content-publisher | ||
- guardian/marley | ||
- guardian/members-data-api | ||
- guardian/membership-common | ||
- guardian/membership-frontend | ||
- guardian/mobile-n10n | ||
- guardian/ophan-geoip-db-refresher | ||
- guardian/ophan-housekeeper | ||
- guardian/pa-football-client | ||
- guardian/payment-failure-comms | ||
- guardian/play-googleauth | ||
- guardian/play-secret-rotation | ||
- guardian/price-migration-engine | ||
- guardian/prism:dependency-updates | ||
- guardian/prout | ||
- guardian/repo-genesis | ||
- guardian/riff-raff:dependency-updates | ||
- guardian/salesforce-message-handler | ||
- guardian/security-hq:dependency-updates | ||
- guardian/ssm-scala:dependency-updates | ||
- guardian/support-frontend | ||
- guardian/support-service-lambdas | ||
- guardian/typerighter | ||
- guardian/zuora-6for6-modifier | ||
- guardian/zuora-full-export |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One surprise here is that with moving from tibdex/github-app-token to scala-steward-org/scala-steward-action for App authentication, we now need to also supply the
github-app-installation-id
, where previously we didn't.In the Scala Steward action, both 'app' & 'installation' tokens seem to get used - so far as I can see, the 'app' is used for performing actions as the bot, while 'installation' is used for in the Scala Steward workspace - I think for cloning the required GitHub repos.
In our case, because we own both the app and the installation, the distinction probably doesn't help us very much, but I imagine it's useful if you're an organisation like VirtusLab, who run Scala Steward on other organisations repositories as a service.