[UI/deploy screen] call updateDeployInfo() more reliably to ensure recent deploys and restrictions reflect the choices
#1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
refresh-deploy-info-on-blur-of-build
branch
from
ee6aef5
to
4a60021
Compare
twrichards
force-pushed
the
refresh-deploy-info-on-blur-of-build
branch
2 times, most recently
from
55f0fe5
to
2b2aa87
Compare
…restrictions reflect the choices more so than now
twrichards
force-pushed
the
refresh-deploy-info-on-blur-of-build
branch
from
2b2aa87
to
609e509
Compare
akash1810
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that since the 'defaulting' to CODE thing was introduced a while back and/or the allowed stages functionality (not sure which) that the list of recent deploys doesn't filter to the selected stage as it does when stage is manually updated.
Similarly and perhaps more importantly it doesn't show deploy restrictions, meaning that you attempt the deploy only for it to fail with a scarier/red message.
This PR addresses that by calling
updateDeployInfo()in a few further places, such as when build is chosen (which is what causes the stage list to be activated with the default).Tested in CODE riff-raff and it's definitely better than it was.