Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloud-formation): Preserve existing tags #1379

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

akash1810
Copy link
Member

@akash1810 akash1810 commented Sep 26, 2024

What does this change?

Update the cloud-formation deployment type to preserve any existing tags on the CloudFormation stack.

How to test

  1. Deploy main to RIff-Raff CODE
  2. Add a random tag 1 to the stack playground-PROD-cdk-playground in the Developer Playground account (from https://github.com/guardian/cdk-playground)
  3. Using Riff-Raff CODE, deploy the project devx::cdk-playground
  4. Observe the tag added in step 2 being removed
  5. Deploy this branch to Riff-Raff CODE
  6. Repeat step 2
  7. Repeat step 3
  8. Observe the tag added in step 6 remaining, and the deployment log stating as such
Screenshot

image

Footnotes

  1. I added the tag Month -> September

Update the `cloud-formation` deployment type to preserve any existing tags on the CloudFormation stack.
@akash1810 akash1810 marked this pull request as ready for review September 26, 2024 07:53
@akash1810 akash1810 requested review from a team as code owners September 26, 2024 07:53
@akash1810 akash1810 merged commit 3c2122a into main Sep 26, 2024
3 checks passed
@akash1810 akash1810 deleted the aa/preserve-existing-tags branch September 26, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants