Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cap the display and mounting of more than 50 pinboards #323

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

twrichards
Copy link
Collaborator

@twrichards twrichards commented Nov 21, 2024

since Apollo doesn't support more than 100 subscriptions (as discovered by real user 🫨 ) and more than 50 open pinboards suggests people aren't transitioning workflow items to the right statuses

in a follow-up PR I'd like to start logging (probably via Sentry) when this happens, otherwise we'll never know.

With the limit artificially set to one for the purposes of screenshot...
image

… doesn't support more than 100 subscriptions and more than 50 suggests people aren't transitioning workflow items to the right statuses
… doesn't support more than 100 subscriptions and more than 50 suggests people aren't transitioning workflow items to the right statuses
@twrichards twrichards force-pushed the handle-too-many-open-pinboards branch from 8591786 to 827034e Compare November 21, 2024 17:56
@twrichards twrichards marked this pull request as ready for review November 21, 2024 17:56
@twrichards twrichards requested a review from a team as a code owner November 21, 2024 17:56
@twrichards twrichards requested a review from paperboyo November 21, 2024 17:56
@twrichards twrichards merged commit 0d2d755 into main Nov 21, 2024
3 checks passed
@twrichards twrichards deleted the handle-too-many-open-pinboards branch November 21, 2024 17:58
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @twrichards 2 minutes and 12 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants