add feature flag mechanism #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe (as json string) and updated via new mutation `changeFeatureFlag`
twrichards
force-pushed
the
feature-flagging-via-users-DB-table
branch
from
6657969 to
4e2ee67
Compare
…ery params (prefix: `pinboardFeatureFlag_`)
twrichards
force-pushed
the
feature-flagging-via-users-DB-table
branch
from
4e2ee67 to
6337e7e
Compare
andrew-nowak
approved these changes
Nov 5, 2024
|
Seen on PROD (merged by @twrichards 4 minutes and 15 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a pre-requisite to #312 we needed a way for users to gradually enrol into the new functionality as they receive 'training', which needed to persist across machines and work consistently in different tools, so storing a new column in the DB seemed sensible ...
featureFlagson theUsertableMyUsertype (just a JSON string, parsed in the client)feautureFlagsshared around the app via the GlobalStateContextchangeFeatureFlagwhich writes key/values to the featureFlags JSONB columnpinboardFeatureFlag_, dropping them from URL once the new mutationchangeFeatureFlaghas been called with the new value (trueorfalse) -- this allows trainers to provide a URL with feature flag query param to users and then it will remain on for the user indefinitely following their trainingonManuallyOpenedPinboardIdsChangedto becomeonMyUserChangesand now fires based on the new mutation too, which allows all connected clients to hear about changes to featureFlags and react accordinglyadd new database column script run against: