configure changesets to publish package as public #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
approved these changes
Dec 10, 2024
rtyley
added a commit
that referenced
this pull request
Jan 7, 2025
As guardian/pan-domain-authentication had both Scala & Node implementations, which both had separate & different release processes (gha-scala-library-release-workflow for Scala, and changesets for node, added in #176), they were competing in the Git tag namespace for version tags. Consequently, we've separated the implementations into separate repositories: * https://github.com/guardian/pan-domain-authentication retains the bulk of documentation and all the Scala code, but loses the Typescript code - that's what we're doing with this change. * https://github.com/guardian/pan-domain-node takes all the Typescript code, losing all other code with guardian/pan-domain-node#24 We've confirmed with guardian/pan-domain-node#27 and https://github.com/guardian/pan-domain-node/releases/tag/v0.5.1 that the Node release process still works in https://github.com/guardian/pan-domain-node .
rtyley
added a commit
that referenced
this pull request
Jan 8, 2025
As guardian/pan-domain-authentication had both Scala & Node implementations, which both had separate & different release processes (gha-scala-library-release-workflow for Scala, and changesets for node, added in #176), they were competing in the Git tag namespace for version tags. Consequently, we've separated the implementations into separate repositories: * https://github.com/guardian/pan-domain-authentication retains the bulk of documentation and all the Scala code, but loses the Typescript code - that's what we're doing with this change. * https://github.com/guardian/pan-domain-node takes all the Typescript code, losing all other code with guardian/pan-domain-node#24 We've confirmed with guardian/pan-domain-node#27 and https://github.com/guardian/pan-domain-node/releases/tag/v0.5.1 that the Node release process still works in https://github.com/guardian/pan-domain-node .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@guardian/digital-cms
The default changesets generated config apparently sets the package visibility as restricted - we intend to publish this package publicly; so set that value here...