Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve manage-frontend 5XX alarm (backend + ELB) #377

Merged
merged 9 commits into from
Mar 18, 2020
Merged

improve manage-frontend 5XX alarm (backend + ELB) #377

merged 9 commits into from
Mar 18, 2020

Conversation

mkuzdowicz
Copy link
Contributor

@mkuzdowicz mkuzdowicz commented Mar 17, 2020 •
edited by twrichards
Loading

Overview

improve manage-frontend 5XX alarm (backend + ELB)

  • trigger alarm on any 500 happening on the application server
  • trigger alarm on any 500 happening on the LoadBalancer

Tests

  • CODE

tested for both situation for

  • failing app server
  • ELB giving 503 when number of EC2 instances was 0

Background

@mkuzdowicz mkuzdowicz marked this pull request as ready for review March 17, 2020 20:51
twrichards
twrichards reviewed Mar 18, 2020
View reviewed changes
cfn.yaml Show resolved Hide resolved
cfn.yaml Outdated Show resolved Hide resolved
@mkuzdowicz mkuzdowicz merged commit c70df10 into master Mar 18, 2020
@mkuzdowicz mkuzdowicz deleted the mkuzdowicz/improve-manage-frontend-5XX-alarm branch March 18, 2020 15:45
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @mkuzdowicz 6 minutes and 30 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twrichards twrichards twrichards approved these changes

Assignees
No one assigned
Labels
Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkuzdowicz @prout-bot @twrichards