Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Commit

Permalink
fix: update JSDoc to match documentation (#294)
Browse files Browse the repository at this point in the history
* update JSDoc to match documentation

@oliverlloyd has mentioned this is the proper way

* fix example
  • Loading branch information
mxdvl authored Nov 5, 2021
1 parent 1deedc6 commit d494fe6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/coreWebVitals.README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { initCoreWebVitals, getCookie } from '@guardian/libs';
// browserId & pageViewId are needed to join up the data downstream.
const init: InitCoreWebVitalsOptions = {
browserId : getCookie({ name: 'bwid', shouldMemoize: true}),
pageViewId: guardian.ophan.config.pageViewId,
pageViewId: guardian.config.ophan.pageViewId,

// Whether to use CODE or PROD endpoints.
isDev: window.location.hostname !== 'www.theguardian.com',
Expand Down
2 changes: 1 addition & 1 deletion src/coreWebVitals.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export const bypassCoreWebVitalsSampling = (team?: TeamName): void => {
* @param init - the initialisation options
* @param init.isDev - used to determine whether to use CODE or PROD endpoints.
* @param init.browserId - identifies the browser. Usually available via `getCookie({ name: 'bwid' })`. Defaults to `null`
* @param init.pageViewId - identifies the page view. Usually available on `guardian.ophan.pageViewId`. Defaults to `null`
* @param init.pageViewId - identifies the page view. Usually available on `guardian.config.ophan.pageViewId`. Defaults to `null`
*
* @param init.sampling - sampling rate for sending data. Defaults to `0.01`.
*
Expand Down

0 comments on commit d494fe6

Please sign in to comment.