add zuora auth logging so we can debug failures easily #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnduffell
commented
Oct 2, 2023
| @@ -36,7 +36,10 @@ object ZuoraAuth extends JsonSupport { | |||
| */ | |||
| var accessToken: String = _ | |||
| private def getAccessToken(): String = { | |||
| Http(s"$zuoraApiHost/oauth/token") | |||
| val logger = java.util.logging.Logger.getGlobal | |||
There was a problem hiding this comment.
this is what it uses elsewhere in this lambda
johnduffell
commented
Oct 2, 2023
| .pipe(read[AccessToken](_)) | ||
| .access_token | ||
| } | ||
| private val timer = new Timer() | ||
| private val timer = new Timer(true) |
There was a problem hiding this comment.
makes this timer a daemon, meaning it doesn't keep the JVM running when the main thread has terminated
https://docs.oracle.com/javase/8/docs/api/java/util/Timer.html#Timer-boolean-
johnduffell
commented
Oct 2, 2023
| .foreach(token => accessToken = token) | ||
| } | ||
| }, | ||
| 0, | ||
| 5 * 60 * 1000, // refresh token every 5 min | ||
| five_minutes, // wait 5 mins for first refresh |
There was a problem hiding this comment.
I noticed it was doing a double auth on startup.
the attempt below happens on app startup, so the initial delay should have been 5 minutes.
original PR it's not mentioned and was probably not considered #16
johnduffell
commented
Oct 2, 2023
| @@ -35,8 +35,11 @@ object ZuoraAuth extends JsonSupport { | |||
| * again. Hence now we periodically refreshes the token (making it def would have performance penalty) | |||
| */ | |||
| var accessToken: String = _ | |||
| private def getAccessToken(): String = { | |||
| Http(s"$zuoraApiHost/oauth/token") | |||
| private def getAccessToken: String = { | |||
There was a problem hiding this comment.
empty brackets was a warning in intellij
graham228221
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an exception in initialiser error in CODE for zuora auth and we can't work out why it doesn't work.
This logging should tell us more about the interaction with zuora.
Logging looks something like this in DEV locally (I've replaced all ids with 1234)