Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the feature switch show-cropping-gutters-switch (still GNM only) #4348

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

twrichards
Copy link
Contributor

@twrichards twrichards commented Oct 7, 2024

…so that all GNM users see the cropping gutters when cropping 5:3 which is now limited to only certain scenarios by query param shouldShowCropGuttersIfApplicable (thanks to #4343 and temporarily also https://github.com/guardian/flexible-content/pull/5049).

Also tweaked the wording in the blue banner to hint users can suggest alternatives back in composer (via guardian/pinboard#312)...
image

@twrichards twrichards force-pushed the remove-feature-flag-for-crop-gutters branch from 2c715d8 to b6c2ec5 Compare October 7, 2024 15:53
Copy link

github-actions bot commented Oct 7, 2024

Base automatically changed from only-display-crop-gutters-via-url-param to main October 8, 2024 11:19
An error occurred while trying to automatically change base from only-display-crop-gutters-via-url-param to main October 8, 2024 11:19
@twrichards twrichards marked this pull request as ready for review November 12, 2024 22:31
@twrichards twrichards requested review from a team as code owners November 12, 2024 22:31
…GNM users see the cropping gutters when cropping 5:3 which is now limited to only certain scenarios by query param `shouldShowCropGuttersIfApplicable` (thanks to #4343)
@twrichards twrichards force-pushed the remove-feature-flag-for-crop-gutters branch from b6c2ec5 to 6670d68 Compare November 18, 2024 15:39
@prout-bot
Copy link

Seen on auth, collections, image-loader (merged by @twrichards 7 minutes and 37 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on leases (merged by @twrichards 7 minutes and 43 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on cropper (merged by @twrichards 7 minutes and 47 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on media-api (merged by @twrichards 7 minutes and 55 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on usage (merged by @twrichards 7 minutes and 55 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on metadata-editor, thrall (merged by @twrichards 8 minutes ago) Please check your changes!

@prout-bot
Copy link

Seen on metadata-editor, media-api (merged by @twrichards 8 minutes and 1 second ago) Please check your changes!

@prout-bot
Copy link

Seen on kahuna (merged by @twrichards 8 minutes and 6 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on kahuna (merged by @twrichards 8 minutes and 7 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants