-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the feature switch show-cropping-gutters-switch
(still GNM only)
#4348
Conversation
2c715d8
to
b6c2ec5
Compare
…GNM users see the cropping gutters when cropping 5:3 which is now limited to only certain scenarios by query param `shouldShowCropGuttersIfApplicable` (thanks to #4343)
b6c2ec5
to
6670d68
Compare
…rnatives back in composer (via guardian/pinboard#312)
6670d68
to
a7e4b8d
Compare
Seen on auth, collections, image-loader (merged by @twrichards 7 minutes and 37 seconds ago) Please check your changes! |
Seen on leases (merged by @twrichards 7 minutes and 43 seconds ago) Please check your changes! |
Seen on cropper (merged by @twrichards 7 minutes and 47 seconds ago) Please check your changes! |
Seen on media-api (merged by @twrichards 7 minutes and 55 seconds ago) Please check your changes! |
Seen on usage (merged by @twrichards 7 minutes and 55 seconds ago) Please check your changes! |
Seen on metadata-editor, thrall (merged by @twrichards 8 minutes ago) Please check your changes! |
Seen on metadata-editor, media-api (merged by @twrichards 8 minutes and 1 second ago) Please check your changes! |
Seen on kahuna (merged by @twrichards 8 minutes and 6 seconds ago) Please check your changes! |
Seen on kahuna (merged by @twrichards 8 minutes and 7 seconds ago) Please check your changes! |
…so that all GNM users see the cropping gutters when cropping 5:3 which is now limited to only certain scenarios by query param
shouldShowCropGuttersIfApplicable
(thanks to #4343 and temporarily also https://github.com/guardian/flexible-content/pull/5049).Also tweaked the wording in the blue banner to hint users can suggest alternatives back in composer (via guardian/pinboard#312)...