Explicitly switch to Sonatype token authentication #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
added a commit
to rtyley/sample-project-using-gha-scala-library-release-workflow
that referenced
this pull request
Jan 16, 2024
rtyley
force-pushed
the
use-sonatype-token-rather-than-username-password-auth
branch
5 times, most recently
from
69174f1 to
8bd424a
Compare
rtyley
added a commit
to guardian/etag-caching
that referenced
this pull request
Jan 18, 2024
rtyley
force-pushed
the
use-sonatype-token-rather-than-username-password-auth
branch
3 times, most recently
from
a9d0967 to
8663357
Compare
rtyley
force-pushed
the
use-sonatype-token-rather-than-username-password-auth
branch
from
8663357 to
10a173c
Compare
rtyley
added a commit
to guardian/etag-caching
that referenced
this pull request
Jun 19, 2024
rtyley
force-pushed
the
use-sonatype-token-rather-than-username-password-auth
branch
2 times, most recently
from
2aa00e8 to
3cf313f
Compare
Token auth is now mandatory: xerial/sbt-sonatype#464 (comment) In January 2024, Sonatype started actively discouraging the legacy username & password method of authentication, recommending token authentication instead: * https://central.sonatype.org/news/20240109_issues_sonatype_org_deprecation/#support-requests * https://central.sonatype.org/publish/generate-token/ In this new scheme, the token is still split into a username/password format, and both are randomised strings, making the username portion a meaningful secret (ie one that can be revoked) and so worthy of being treated as a secret.
rtyley
force-pushed
the
use-sonatype-token-rather-than-username-password-auth
branch
from
3cf313f to
23a148a
Compare
rtyley
commented
Jun 19, 2024
Comment on lines
+416
to
+417
| export SONATYPE_USERNAME="${SONATYPE_TOKEN%%:*}" # See https://github.com/xerial/sbt-sonatype/pull/62 | ||
| export SONATYPE_PASSWORD="${SONATYPE_TOKEN#*:}" |
There was a problem hiding this comment.
These two lines (using BASH Shell Parameter Expansion to chop the user:pass token string into user & pass) will no longer be necessary if xerial/sbt-sonatype#464 is merged & released.
Note that export is crucial here - without it, sbt "sonatypeBundleRelease" doesn't receive the SONATYPE_USERNAME & SONATYPE_PASSWORD. This is because exported variables get passed on to child processes, not-exported variables do not - and sbt runs as a child process.
rtyley
commented
Jun 19, 2024
| * `AUTOMATED_MAVEN_RELEASE_SONATYPE_PASSWORD` | ||
| * `AUTOMATED_MAVEN_RELEASE_SONATYPE_TOKEN` |
There was a problem hiding this comment.
This change is covered by https://github.com/guardian/github-secret-access/pull/55.
rtyley
added a commit
to guardian/etag-caching
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/etag-caching
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/etag-caching
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/identity-test-users
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/atom-maker
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/commercial-shared
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/content-api-models
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/content-atom
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/content-api-client-aws
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/content-api-firehose-client
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/content-api-scala-client
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/play-secret-rotation
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/redirect-resolver
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/scrooge-extras
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/tags-thrift-schema
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/targeting-client
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/thrift-serializer
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/guardian-configuration
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/janus-app
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/mobile-logstash-encoder
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/mobile-n10n
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/pan-domain-authentication
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/simple-configuration
that referenced
this pull request
Jun 20, 2024
rtyley
added a commit
to guardian/source-apps
that referenced
this pull request
Jun 20, 2024
This was referenced Jun 20, 2024
rtyley
added a commit
to rtyley/sample-project-using-gha-scala-library-release-workflow
that referenced
this pull request
Jun 26, 2024
In particular, updating config for: * guardian/gha-scala-library-release-workflow#23 - Sonatype token authentication
rtyley
added a commit
to rtyley/sample-project-using-gha-scala-library-release-workflow
that referenced
this pull request
Jun 26, 2024
In particular, updating config for: * guardian/gha-scala-library-release-workflow#23 - Sonatype token authentication
rtyley
added a commit
to scanamo/scanamo
that referenced
this pull request
Jun 26, 2024
In particular, updating config for: * guardian/gha-scala-library-release-workflow#23 - Sonatype token authentication
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #39, updating
gha-scala-library-release-workflowto take a single colon-separated composite API token (username:password) for auth, rather than the old Nexus UI username & password combination, which is now rejected by Sonatype.Changes required to repos using
gha-scala-library-release-workflowAll repos need to update their
.github/workflows/release.ymlto use the workflow's newSONATYPE_TOKENparameter (the oldSONATYPE_PASSWORDparameter has been dropped):Before
After
Updating many projects at once
As in #36, it was possible to update many of the ~30 projects using
gha-scala-library-release-workflowusing a switch-release-yml-to-token-auth.sh script that I hammered together:Testing
An example of a successful release with this change (at commit 23a148a) is:
https://github.com/guardian/etag-caching/actions/runs/9588801840
See also
SONATYPE_TOKENenvironment variable for token authentication xerial/sbt-sonatype#464