Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete snyk action #1744

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Delete snyk action #1744

merged 4 commits into from
Dec 17, 2024

Conversation

Georges-GNM
Copy link
Contributor

What's changed?

This action has started failing yesterday on the back of Github's removal of sbt from the runner base images.

Since this PR merged a couple of weeks ago, we've been sending sbt dependencies for vulnerability monitoring, and per Devx, it should be ok to delete the snyk action as it's being deprecated soon.

Implementation notes

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@Georges-GNM Georges-GNM marked this pull request as ready for review December 12, 2024 09:48
@Georges-GNM Georges-GNM requested a review from a team as a code owner December 12, 2024 09:48
Copy link
Member

@davidfurey davidfurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete the associated Snyk project once this PR is merged

@Georges-GNM Georges-GNM merged commit 944edd9 into main Dec 17, 2024
13 checks passed
@Georges-GNM Georges-GNM deleted the gl/remove-snyk-action branch December 17, 2024 14:37
@prout-bot
Copy link

Seen on PROD (merged by @Georges-GNM 20 minutes and 11 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants