[Fairground] Display image as 4:5 in relevant collections #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Georges-GNM
force-pushed
the
gl/4-5-trail
branch
from
84a34fa to
b042585
Compare
Georges-GNM
changed the title
abeddow91
approved these changes
Dec 17, 2024
| @@ -52,20 +52,20 @@ const squareStyle = ` | |||
| `; | |||
|
|
|||
| const getVariableImageContainerStyle = ({ | |||
| portrait = false, | |||
| shouldShowPortrait = false, | |||
|
Seen on PROD (merged by @Georges-GNM 8 minutes and 37 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Part of this ticket. Displays trail and thumbnail images with a 4:5 aspect ratio for relevant collections.
Implementation note
This was made using the same pattern previously implemented for square/landscape54 images being displayed. We're at the point of having the same logic effectively being repeated three times, so it's an opportunity for a refactor, which I've started putting together, but thought that change was best left for a separate PR.
Screenshots
These examples contrast a scrollable feature collection, which uses 4:5 images, and a scrollable small, which uses landscape 5:4. The image getting displayed is the one automatically selected when adding the story to the collection (so no manual replacing/cropping of the image).
Thumbnail:
Trail image:
General
Client