default pinboard feature switch to ON in all envs #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s stage specific default) following release of guardian/pinboard#312
jonathonherbert
approved these changes
Nov 25, 2024
|
Seen on PROD (merged by @twrichards 6 minutes and 29 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and remove previous stage specific default) following release of guardian/pinboard#312 - which has its own feature switch mechanism for controlling whether pinboard should 'display', but this feature switch was as to whether pinboard script is loaded at all, which we need it to be for it to evaluate pinboard's own feature switch, but stopped short of removing the feature switch entirely in case something goes wrong and users need to be able to explicitly turn it off (removal PR is #1734 though)