-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe filters #1732
Recipe filters #1732
Conversation
b5af406
to
1c68e88
Compare
1c68e88
to
89b0083
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! An endpoint per keyword seems a lot, but perhaps we're worried about how this data grows, and it eliminates a class of problem.
This is going to be really useful.
It'd be lovely to display the doc counts alongside the option values, to give users an idea of how many recipes they're likely to see for a given option — guiding filtering behaviour and potentially saving some clicks. (Ideally, they'd be running totals that would update for combinations of options, but that's probably a larger piece of work.)
797c321
to
ed75186
Compare
What's changed?
Adds options to specify "celebration" and "suitable for diet" filters.
Implementation notes
These are currently simple dropdown options, we should probably look at something more generic and sophisticated but this works at the moment
Checklist
General
Client