Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two extra empty collections to daily editions life front on Sundays. #1538

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

dblatcher
Copy link
Contributor

What's changed?

Adding two extra collections / containers to the config for the "Life" front for Sundays on the Daily Edition (was 5 in total, now 7) in response to request from the Production team.

Implementation notes

Checklist

General

  • [-] 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@dblatcher dblatcher requested a review from a team as a code owner December 5, 2023 09:31
Copy link
Member

@davidfurey davidfurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dblatcher dblatcher merged commit d39189a into main Dec 6, 2023
1 check passed
@dblatcher dblatcher deleted the dblatcher/seven-containers-on-sunday-life branch December 6, 2023 10:20
@prout-bot
Copy link

Seen on PROD (merged by @dblatcher 192 hours, 55 minutes and 53 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants