-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fronts client v2 deps update #1529
Conversation
I see that you've removed the |
I ran eg for Will push a change! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and running as expected locally.
Had some odd behaviour when I first tried to run - permissions errors to do with yarn and babel that were preventing the startup script from running. Deleted node_modules
and it started working. Don't exactly understand what happened but thought it worth mentioning in case it happens again down the line.
Seen on PROD (merged by @dblatcher 15 minutes and 39 seconds ago) Please check your changes! |
* update babel, remove guration * add missing react peer deps * chore: specify event types * chore: type ref props * FocusWrapper cast to same type as Wrapper to preserve native props * MetaContainerProps * upgrade jest and webapck * upgrade enyme * upgrade recharts * body parse and loadash * bump webpack-dev-server * markdown toc * bump webpack-cli * bump jest-enzyme * upgrade prosemirror, remove stub type modules * not using babel loader * upgrade webpack loaders * yrn upgrade on jest * upgrade to jest 24 * upgrade to jest 25 * update to jest 26 * remove babel-jest - not used * react-dates update * moment and react-dates * bump recharts * bump react-redux * bunp express * lint * bump eslint * bump prosemirror packages to versions set in yarn.lock
What's changed?
https://trello.com/c/yMRC0Qmx/1786-fix-vulnerabilities-tool-v2
styled-components
- required some extra specifications of types in the source code - EG the type of Events in onChange functionsImplementation notes
This PR makes significant reduction in vulnerabilities, but there is more to do. The main targets area seem likely to require significant changes to source code and tests, which seemed best handled on dedicated PRs:
testcafe
(integration test suite) is to source of 27/45 remaining vulnerabilities, but there are several breaking changes to address and version conflicts for upgrading jest - might be worth looking into switching to Cypress since it is more commonly used in Guardian projectsstyled-components
may need an upgrade to v6+ at some point, but the way we handle theming (by overriding and re-exporting base types) no longer seems to be supported: see this issue What happened to ThemedCssFunction and SimpleInterpolation? [v5 to v6 migration] styled-components/styled-components#4087Checklist
General
Client