Use predefined sbt License object
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `License` object was added in sbt v1.6.2 (https://github.com/sbt/sbt/releases/tag/v1.6.2), with PR sbt/librarymanagement#395 . It's more concise, and gives some consistency for how licenses are expressed. Specifying a license is *required* for submitting a project to Maven Central: https://central.sonatype.org/publish/requirements/#license-information
|
Mock info: This PR Breaks Binary Compatibility when compared against most recent release 3.0.0. Details... |
rtyley
added a commit
to guardian/gha-scala-library-release-workflow
that referenced
this pull request
Dec 22, 2023
We had a failed release on https://github.com/guardian/targeting-client after guardian/targeting-client#37 accidentally removed the `license` setting: https://github.com/guardian/targeting-client/actions/runs/7299896704/job/19893644176#step:5:56 ``` 2023-12-22 12:37:31.245Z error [SonatypeClient] [close] Failed - (SonatypeClient.scala:181) 2023-12-22 12:37:31.245Z error [SonatypeClient] Activity name:close, started:2023-12-22T12:36:34.296Z - (SonatypeClient.scala:469) 2023-12-22 12:37:31.246Z error [SonatypeClient] Failed: pom-staging, failureMessage:Invalid POM: /com/gu/targeting-client/client-play-json-v30_2.13/1.1.5/client-play-json-v30_2.13-1.1.5.pom: License information missing - (SonatypeClient.scala:387) ``` Specifying a license is *required* for submitting a project to Maven Central: https://central.sonatype.org/publish/requirements/#license-information Note that sbt v1.6.2 and above (thanks to sbt/librarymanagement#395) supply a `License` object that means you can define the license much more concisely: ``` licenses := Seq("Apache-2.0" -> url("https://www.apache.org/licenses/LICENSE-2.0")) ``` Used successfully in guardian/etag-caching#29
rtyley
added a commit
to guardian/gha-scala-library-release-workflow
that referenced
this pull request
Dec 22, 2023
We had a failed release on https://github.com/guardian/targeting-client after guardian/targeting-client#37 accidentally removed the `license` setting: https://github.com/guardian/targeting-client/actions/runs/7299896704/job/19893644176#step:5:56 ``` 2023-12-22 12:37:31.245Z error [SonatypeClient] [close] Failed - (SonatypeClient.scala:181) 2023-12-22 12:37:31.245Z error [SonatypeClient] Activity name:close, started:2023-12-22T12:36:34.296Z - (SonatypeClient.scala:469) 2023-12-22 12:37:31.246Z error [SonatypeClient] Failed: pom-staging, failureMessage:Invalid POM: /com/gu/targeting-client/client-play-json-v30_2.13/1.1.5/client-play-json-v30_2.13-1.1.5.pom: License information missing - (SonatypeClient.scala:387) ``` Specifying a license is *required* for submitting a project to Maven Central: https://central.sonatype.org/publish/requirements/#license-information Note that sbt v1.6.2 and above (thanks to sbt/librarymanagement#395) supply a `License` object that means you can define the license much more concisely: ``` licenses := Seq(License.Apache2) ``` Used successfully in guardian/etag-caching#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Licenseobject was added in sbt v1.6.2 with PR sbt/librarymanagement#395 .It's more concise, and gives some consistency for how licenses are expressed.
Specifying a license is required for submitting a project to Maven Central.