Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from deprecated node-sass to sass #141

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

Fweddi
Copy link
Contributor

@Fweddi Fweddi commented Jul 18, 2024

What does this change?

node-sass has been deprecated, and it doesn't seem any versions of it are compatible with ARM (now the architecture of most dev machines). This PR replaces the node-sass library with sass.

The new library requires a couple of syntax changes.

How to test

See if you can run this tool locally on your ARM machine.

I have deployed this branch to CODE. Does it work as before?

@Fweddi Fweddi requested a review from a team July 18, 2024 14:28
Copy link
Contributor

@jonathonherbert jonathonherbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to say goodbye to node-sass! Version currently deployed on CODE looks good. 👍

@Fweddi Fweddi merged commit 18be4ed into main Jul 18, 2024
3 checks passed
@Fweddi Fweddi deleted the fp/upgrade-sass-for-arm branch July 18, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants