Update scala and sbt versions for scala-steward #27
Conversation
This repository recently caused scala-steward to fail, because it doesn’t currently meet the minimum required sbt and scala versions for scala steward to work. (Those versions are outlined in [this issue](guardian/maintaining-scala-projects#7). This commit updates the sbt version in use to the newest versions and the two scala versions in use to the latest patch versions for those minor versions. This should be sufficient to let scala-steward run on this repository: I have managed to successfully run `sbt +test` locally with these changes using Java 21.
|
I’m not super familiar with this repository and who owns it, so I have requested review from two recent contributors! |
I like to look to see which GitHub team is an 'admin' in the settings (this might not be accessible to you if you're not an admin on this repo): 
In this case, @guardian/identity is the only admin, so I guess they're the owners? This would also make sense because these are the only repos using this library so far as I can tell from GitHub search: |
There was a problem hiding this comment.
This looks great to me! As mentioned in guardian/maintaining-scala-projects#7, we need to be on these minimum versions to allow compiling with Scala 21:
Thanks for the suggestion, I didn’t think to check that. It looks like I don’t have access fot this repository, alright. |
|
I can confirm that's fixed the Scala Steward workflow:
Scala Steward has now raised these for this repo: |
This repository recently caused scala-steward to fail, because it doesn’t currently meet the minimum required sbt and scala versions for scala steward to work. (Those versions are outlined in this issue.
This PR updates the sbt version in use to the newest versions and the two scala versions in use to the latest patch versions for those minor versions.
This should be sufficient to let scala-steward run on this repository: I have managed to successfully run
sbt +testlocally with these changes using Java 21.