Onward Content Design Refactor #9691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -405,8 +410,10 @@ export const Card = ({ | |||
| return ( | |||
| <CardWrapper | |||
| format={format} | |||
| showTopBar={!isOnwardContent} | |||
There was a problem hiding this comment.
Have passed this rather than just using isOnwardContent in the CardWrapper as it is more abstracted and reusable in future
|
Size Change: -13 kB (-2%) Total Size: 733 kB
ℹ️ View Unchanged
|
sophie-macmillan
changed the title
abeddow91
approved these changes
Nov 29, 2023
…ndary, depending if its a Front carousel or an article carousel
sophie-macmillan
force-pushed
the
sm-onward-content-design-refactor
branch
from
9be27c2 to
5d69bd7
Compare
|
I think it we're going to refactor cards we should consider moving to CSS grid which would drastically simplify their CSS and DOM structure. Happy to demo some stuff |
I'm not opposed to using grid but I don't really think this PR is the place for it - I've mainly made use of the existing card with some minor tweaks (top bar showing, rounded corners and and different background). Think it looks like I've made more changes than I have because i've un-nested some css! |
mxdvl
reviewed
Nov 30, 2023
mxdvl
approved these changes
Nov 30, 2023
…of the card for onwards content
sophie-macmillan
added
run_chromatic
|
Seen on PROD (merged by @sophie-macmillan 9 minutes and 9 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This updates the design for all the onwards contents carousels. The front carousel should not be updated so we use the
isOnwardsContentprop to distinguish between the two.I didn't think the changes required were significant to create a new carousel or card, but if whoever reviews this feels differently we can discuss and split it out. The card is quite big and has a fair amount of logic in it already.
Why?
Part of a redesign
Resolves #7390
Screenshots