RichLink support darkmode #9683

DanielCliftonGuardian · 2023-11-28T11:18:36Z

What does this change?

This adds dark mode styles for the richlink component and deletes defunct styles in decidePalette

Why?

Resolves #9619

Screenshots

github-actions · 2023-11-28T11:25:06Z

Size Change: -1 B (0%)

Total Size: 724 kB

ℹ️ View Unchanged

Filename	Size	Change
`dotcom-rendering/dist/100.web.********************.js`	990 B	0 B
`dotcom-rendering/dist/1024.web.********************.js`	2.75 kB	0 B
`dotcom-rendering/dist/1076.web.********************.js`	3.08 kB	0 B
`dotcom-rendering/dist/1121.web.********************.js`	2.58 kB	0 B
`dotcom-rendering/dist/1136.web.********************.js`	884 B	0 B
`dotcom-rendering/dist/1178.web.********************.js`	504 B	0 B
`dotcom-rendering/dist/1406.web.********************.js`	5.09 kB	0 B
`dotcom-rendering/dist/1418.web.********************.js`	9.98 kB	0 B
`dotcom-rendering/dist/1465.web.********************.js`	3.32 kB	0 B
`dotcom-rendering/dist/1520.web.********************.js`	492 B	0 B
`dotcom-rendering/dist/1521.web.********************.js`	5.48 kB	0 B
`dotcom-rendering/dist/1659.web.********************.js`	518 B	0 B
`dotcom-rendering/dist/1714.web.********************.js`	3.5 kB	0 B
`dotcom-rendering/dist/1987.web.********************.js`	3.15 kB	0 B
`dotcom-rendering/dist/2092.web.********************.js`	849 B	0 B
`dotcom-rendering/dist/2096.web.********************.js`	13 kB	0 B
`dotcom-rendering/dist/2186.web.********************.js`	916 B	0 B
`dotcom-rendering/dist/2323.web.********************.js`	3.88 kB	0 B
`dotcom-rendering/dist/2351.web.********************.js`	3.34 kB	0 B
`dotcom-rendering/dist/2394.web.********************.js`	5.48 kB	0 B
`dotcom-rendering/dist/2510.web.********************.js`	663 B	0 B
`dotcom-rendering/dist/2511.web.********************.js`	819 B	0 B
`dotcom-rendering/dist/254.web.********************.js`	638 B	0 B
`dotcom-rendering/dist/2546.web.********************.js`	3.72 kB	0 B
`dotcom-rendering/dist/2848.web.********************.js`	16.2 kB	0 B
`dotcom-rendering/dist/2879.web.********************.js`	910 B	0 B
`dotcom-rendering/dist/2919.web.********************.js`	900 B	0 B
`dotcom-rendering/dist/2923.web.********************.js`	720 B	0 B
`dotcom-rendering/dist/3030.web.********************.js`	957 B	0 B
`dotcom-rendering/dist/3111.web.********************.js`	590 B	0 B
`dotcom-rendering/dist/3146.web.********************.js`	6.53 kB	0 B
`dotcom-rendering/dist/3149.web.********************.js`	636 B	0 B
`dotcom-rendering/dist/3265.web.********************.js`	916 B	0 B
`dotcom-rendering/dist/3302.web.********************.js`	820 B	0 B
`dotcom-rendering/dist/3389.web.********************.js`	884 B	0 B
`dotcom-rendering/dist/3662.web.********************.js`	3.13 kB	0 B
`dotcom-rendering/dist/374.web.********************.js`	5.09 kB	0 B
`dotcom-rendering/dist/3795.web.********************.js`	797 B	0 B
`dotcom-rendering/dist/3968.web.********************.js`	3.79 kB	0 B
`dotcom-rendering/dist/4012.web.********************.js`	783 B	0 B
`dotcom-rendering/dist/4251.web.********************.js`	8.9 kB	0 B
`dotcom-rendering/dist/4349.web.********************.js`	775 B	0 B
`dotcom-rendering/dist/4591.web.********************.js`	404 B	0 B
`dotcom-rendering/dist/4593.web.********************.js`	1.74 kB	0 B
`dotcom-rendering/dist/4627.web.********************.js`	783 B	0 B
`dotcom-rendering/dist/4797.web.********************.js`	744 B	0 B
`dotcom-rendering/dist/480.web.********************.js`	524 B	0 B
`dotcom-rendering/dist/489.web.********************.js`	5.22 kB	0 B
`dotcom-rendering/dist/5332.web.********************.js`	820 B	0 B
`dotcom-rendering/dist/5495.web.********************.js`	676 B	0 B
`dotcom-rendering/dist/5515.web.********************.js`	30 kB	0 B
`dotcom-rendering/dist/5688.web.********************.js`	3.79 kB	0 B
`dotcom-rendering/dist/5744.web.********************.js`	720 B	0 B
`dotcom-rendering/dist/5843.web.********************.js`	4.69 kB	0 B
`dotcom-rendering/dist/6068.web.********************.js`	775 B	0 B
`dotcom-rendering/dist/6126.web.********************.js`	2.23 kB	0 B
`dotcom-rendering/dist/6295.web.********************.js`	999 B	0 B
`dotcom-rendering/dist/639.web.********************.js`	951 B	0 B
`dotcom-rendering/dist/6428.web.********************.js`	741 B	0 B
`dotcom-rendering/dist/657.web.********************.js`	2.46 kB	0 B
`dotcom-rendering/dist/6609.web.********************.js`	872 B	0 B
`dotcom-rendering/dist/6967.web.********************.js`	850 B	0 B
`dotcom-rendering/dist/721.web.********************.js`	4.24 kB	0 B
`dotcom-rendering/dist/7569.web.********************.js`	4.83 kB	0 B
`dotcom-rendering/dist/7650.web.********************.js`	23 kB	0 B
`dotcom-rendering/dist/7701.web.********************.js`	647 B	0 B
`dotcom-rendering/dist/8085.web.********************.js`	2.59 kB	0 B
`dotcom-rendering/dist/8112.web.********************.js`	3.37 kB	0 B
`dotcom-rendering/dist/818.web.********************.js`	2.85 kB	0 B
`dotcom-rendering/dist/8268.web.********************.js`	4.24 kB	0 B
`dotcom-rendering/dist/8395.web.********************.js`	580 B	0 B
`dotcom-rendering/dist/8401.web.********************.js`	922 B	0 B
`dotcom-rendering/dist/8414.web.********************.js`	4.92 kB	0 B
`dotcom-rendering/dist/8620.web.********************.js`	5.78 kB	0 B
`dotcom-rendering/dist/8924.web.********************.js`	3.22 kB	0 B
`dotcom-rendering/dist/9196.web.********************.js`	784 B	0 B
`dotcom-rendering/dist/9251.web.********************.js`	2.25 kB	0 B
`dotcom-rendering/dist/9390.web.********************.js`	743 B	0 B
`dotcom-rendering/dist/9422.web.********************.js`	614 B	0 B
`dotcom-rendering/dist/9581.web.********************.js`	797 B	0 B
`dotcom-rendering/dist/9582.web.********************.js`	710 B	0 B
`dotcom-rendering/dist/9597.web.********************.js`	3.25 kB	0 B
`dotcom-rendering/dist/9617.web.********************.js`	1 kB	0 B
`dotcom-rendering/dist/9724.web.********************.js`	5.01 kB	0 B
`dotcom-rendering/dist/AdPortals-importable.web.********************.js`	3.63 kB	0 B
`dotcom-rendering/dist/AlreadyVisited-importable.web.********************.js`	412 B	0 B
`dotcom-rendering/dist/AppEmailSignUp-importable.web.********************.js`	7.26 kB	0 B
`dotcom-rendering/dist/AppsEpic-importable.web.********************.js`	4 kB	0 B
`dotcom-rendering/dist/AppsFooter-importable.web.********************.js`	3.31 kB	0 B
`dotcom-rendering/dist/AppsLightboxImage-importable.web.********************.js`	2.92 kB	0 B
`dotcom-rendering/dist/AppsLightboxImageStore-importable.web.********************.js`	2.4 kB	0 B
`dotcom-rendering/dist/AudioAtomWrapper-importable.web.********************.js`	3.51 kB	0 B
`dotcom-rendering/dist/AustralianTerritorySwitcher-importable.web.********************.js`	4.6 kB	0 B
`dotcom-rendering/dist/Branding-importable.web.********************.js`	2.26 kB	0 B
`dotcom-rendering/dist/braze-web-sdk-core.web.********************.js`	36.9 kB	0 B
`dotcom-rendering/dist/BrazeMessaging-importable.web.********************.js`	5.28 kB	0 B
`dotcom-rendering/dist/CalloutBlockComponent-importable.web.********************.js`	6.67 kB	0 B
`dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.web.********************.js`	6 kB	0 B
`dotcom-rendering/dist/CardCommentCount-importable.web.********************.js`	2.89 kB	0 B
`dotcom-rendering/dist/Carousel-importable.web.********************.js`	7.65 kB	0 B
`dotcom-rendering/dist/CarouselForNewsletters-importable.web.********************.js`	5.39 kB	0 B
`dotcom-rendering/dist/ChartAtom-importable.web.********************.js`	500 B	0 B
`dotcom-rendering/dist/CommentCount-importable.web.********************.js`	3.06 kB	0 B
`dotcom-rendering/dist/DiscussionContainer-importable.web.********************.js`	23.9 kB	0 B
`dotcom-rendering/dist/DiscussionMeta-importable.web.********************.js`	3.66 kB	0 B
`dotcom-rendering/dist/DocumentBlockComponent-importable.web.********************.js`	3.3 kB	0 B
`dotcom-rendering/dist/EmbedBlockComponent-importable.web.********************.js`	3.85 kB	0 B
`dotcom-rendering/dist/EnhancePinnedPost-importable.web.********************.js`	1.97 kB	0 B
`dotcom-rendering/dist/FetchOnwardsData-importable.web.********************.js`	2.5 kB	0 B
`dotcom-rendering/dist/FilterKeyEventsToggle-importable.web.********************.js`	3.32 kB	0 B
`dotcom-rendering/dist/FocusStyles-importable.web.********************.js`	607 B	0 B
`dotcom-rendering/dist/FollowWrapper-importable.web.********************.js`	2.85 kB	0 B
`dotcom-rendering/dist/FooterLabel-importable.web.********************.js`	336 B	0 B
`dotcom-rendering/dist/frameworks.web.********************.js`	20.8 kB	0 B
`dotcom-rendering/dist/GetCricketScoreboard-importable.web.********************.js`	3.49 kB	0 B
`dotcom-rendering/dist/GetMatchNav-importable.web.********************.js`	9.61 kB	0 B
`dotcom-rendering/dist/GetMatchStats-importable.web.********************.js`	1.52 kB	0 B
`dotcom-rendering/dist/GetMatchTabs-importable.web.********************.js`	2.55 kB	0 B
`dotcom-rendering/dist/guardian-braze-components-banner.web.********************.js`	13.4 kB	0 B
`dotcom-rendering/dist/guardian-braze-components-end-of-article.web.********************.js`	9 kB	0 B
`dotcom-rendering/dist/GuideAtomWrapper-importable.web.********************.js`	790 B	0 B
`dotcom-rendering/dist/HeaderTopBar-importable.web.********************.js`	10.8 kB	0 B
`dotcom-rendering/dist/index.web.********************.js`	45.2 kB	-1 B (0%)
`dotcom-rendering/dist/InstagramBlockComponent-importable.web.********************.js`	3.38 kB	0 B
`dotcom-rendering/dist/InteractiveBlockComponent-importable.web.********************.js`	5.92 kB	0 B
`dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.web.********************.js`	3.79 kB	0 B
`dotcom-rendering/dist/InteractiveSupportButton-importable.web.********************.js`	3.83 kB	0 B
`dotcom-rendering/dist/KeyEventsCarousel-importable.web.********************.js`	2.7 kB	0 B
`dotcom-rendering/dist/KnowledgeQuizAtom-importable.web.********************.js`	3.52 kB	0 B
`dotcom-rendering/dist/LatestLinks-importable.web.********************.js`	1.2 kB	0 B
`dotcom-rendering/dist/LightboxHash-importable.web.********************.js`	430 B	0 B
`dotcom-rendering/dist/LightboxJavascript-importable.web.********************.js`	4.64 kB	0 B
`dotcom-rendering/dist/LiveBlogEpic-importable.web.********************.js`	3.86 kB	0 B
`dotcom-rendering/dist/Liveness-importable.web.********************.js`	3.34 kB	0 B
`dotcom-rendering/dist/ManyNewsletterSignUp-importable.web.********************.js`	4.98 kB	0 B
`dotcom-rendering/dist/MapEmbedBlockComponent-importable.web.********************.js`	5.33 kB	0 B
`dotcom-rendering/dist/Metrics-importable.web.********************.js`	2.29 kB	0 B
`dotcom-rendering/dist/MostViewedFooter-importable.web.********************.js`	5.68 kB	0 B
`dotcom-rendering/dist/MostViewedFooterData-importable.web.********************.js`	8.35 kB	0 B
`dotcom-rendering/dist/MostViewedRightWrapper-importable.web.********************.js`	3.73 kB	0 B
`dotcom-rendering/dist/OnwardsUpper-importable.web.********************.js`	4.17 kB	0 B
`dotcom-rendering/dist/PersonalityQuizAtom-importable.web.********************.js`	3.65 kB	0 B
`dotcom-rendering/dist/ProfileAtom-importable.web.********************.js`	547 B	0 B
`dotcom-rendering/dist/ProfileAtomWrapper-importable.web.********************.js`	810 B	0 B
`dotcom-rendering/dist/PulsingDot-importable.web.********************.js`	744 B	0 B
`dotcom-rendering/dist/QandaAtom-importable.web.********************.js`	542 B	0 B
`dotcom-rendering/dist/ReaderRevenueDev-importable.web.********************.js`	466 B	0 B
`dotcom-rendering/dist/readerRevenueDevUtils.web.********************.js`	2.44 kB	0 B
`dotcom-rendering/dist/ReaderRevenueLinks-importable.web.********************.js`	6.18 kB	0 B
`dotcom-rendering/dist/RelativeTime-importable.web.********************.js`	1.92 kB	0 B
`dotcom-rendering/dist/RichLinkComponent-importable.web.********************.js`	6.18 kB	0 B
`dotcom-rendering/dist/SecureSignupIframe-importable.web.********************.js`	4.93 kB	0 B
`dotcom-rendering/dist/SendAMessage-importable.web.********************.js`	4.6 kB	0 B
`dotcom-rendering/dist/SendTargetingParams-importable.web.********************.js`	2.08 kB	0 B
`dotcom-rendering/dist/sentry.web.********************.js`	772 B	0 B
`dotcom-rendering/dist/SetABTests-importable.web.********************.js`	3.43 kB	0 B
`dotcom-rendering/dist/SetAdTargeting-importable.web.********************.js`	481 B	0 B
`dotcom-rendering/dist/shimport.web.********************.js`	2.78 kB	0 B
`dotcom-rendering/dist/ShowHideContainers-importable.web.********************.js`	642 B	0 B
`dotcom-rendering/dist/ShowMore-importable.web.********************.js`	5.61 kB	0 B
`dotcom-rendering/dist/SignInGateMain.web.********************.js`	3.86 kB	0 B
`dotcom-rendering/dist/SignInGateMainCheckoutComplete.web.********************.js`	4.94 kB	0 B
`dotcom-rendering/dist/SignInGateSelector-importable.web.********************.js`	5.55 kB	0 B
`dotcom-rendering/dist/SlotBodyEnd-importable.web.********************.js`	6.57 kB	0 B
`dotcom-rendering/dist/SpotifyBlockComponent-importable.web.********************.js`	5.18 kB	0 B
`dotcom-rendering/dist/StickyBottomBanner-importable.web.********************.js`	5.74 kB	0 B
`dotcom-rendering/dist/SubNav-importable.web.********************.js`	2.36 kB	0 B
`dotcom-rendering/dist/SupportTheG-importable.web.********************.js`	6.3 kB	0 B
`dotcom-rendering/dist/TableOfContents-importable.web.********************.js`	2.86 kB	0 B
`dotcom-rendering/dist/TimelineAtom-importable.web.********************.js`	1.22 kB	0 B
`dotcom-rendering/dist/TweetBlockComponent-importable.web.********************.js`	1.01 kB	0 B
`dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.web.********************.js`	3.39 kB	0 B
`dotcom-rendering/dist/VideoFacebookBlockComponent-importable.web.********************.js`	5.35 kB	0 B
`dotcom-rendering/dist/VineBlockComponent-importable.web.********************.js`	3.24 kB	0 B
`dotcom-rendering/dist/WeatherWrapper-importable.web.********************.js`	5.41 kB	0 B
`dotcom-rendering/dist/YoutubeBlockComponent-importable.web.********************.js`	3.77 kB	0 B

_{compressed-size-action}

JamieB-gu

Looks good! A few comments/suggestions.

dotcom-rendering/src/components/RichLink.stories.tsx

dotcom-rendering/src/components/RichLink.tsx

dotcom-rendering/src/palette.ts

dotcom-rendering/src/components/RichLink.stories.tsx

dotcom-rendering/src/palette.ts

dotcom-rendering/src/components/RichLink.tsx

dotcom-rendering/src/palette.ts

dotcom-rendering/src/components/RichLink.tsx

dotcom-rendering/src/palette.ts

dotcom-rendering/src/components/RichLink.tsx

prout-bot · 2023-12-05T15:37:12Z

Seen on PROD (merged by @DanielCliftonGuardian 99 hours, 55 minutes and 22 seconds ago) Please check your changes!

richlink darkmode

4ada0b4

DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Nov 28, 2023

github-actions bot added the dotcom-rendering label Nov 28, 2023

DanielCliftonGuardian added 2 commits November 28, 2023 12:09

correct styles

5d891a8

Update palette.ts

2631891

DanielCliftonGuardian marked this pull request as ready for review November 28, 2023 12:49

DanielCliftonGuardian requested a review from a team as a code owner November 28, 2023 12:49

JamieB-gu reviewed Nov 28, 2023

View reviewed changes

dotcom-rendering/src/components/RichLink.stories.tsx Show resolved Hide resolved

dotcom-rendering/src/components/RichLink.tsx Outdated Show resolved Hide resolved

dotcom-rendering/src/palette.ts Outdated Show resolved Hide resolved

cemms1 reviewed Nov 28, 2023

View reviewed changes

mxdvl reviewed Nov 29, 2023

View reviewed changes

dotcom-rendering/src/components/RichLink.tsx Outdated Show resolved Hide resolved

dotcom-rendering/src/components/RichLink.tsx Outdated Show resolved Hide resolved

DanielCliftonGuardian added 2 commits November 29, 2023 12:52

Refactor

6323809

Update palette.ts

3f7b883

abeddow91 approved these changes Nov 30, 2023

View reviewed changes

dotcom-rendering/src/components/RichLink.tsx Outdated Show resolved Hide resolved

cemms1 reviewed Nov 30, 2023

View reviewed changes

dotcom-rendering/src/palette.ts Show resolved Hide resolved

dotcom-rendering/src/palette.ts Show resolved Hide resolved

dotcom-rendering/src/components/RichLink.tsx Outdated Show resolved Hide resolved

DanielCliftonGuardian added 5 commits December 1, 2023 10:12

Update RichLink.tsx

fae6dbf

Merge branch 'main' into richlink-darkmode

a75098d

Update palette.ts

5e03c4d

merge conflicts

a8de762

Merge branch 'main' into richlink-darkmode

12d81cf

DanielCliftonGuardian merged commit 8c2d106 into main Dec 1, 2023
30 checks passed

DanielCliftonGuardian deleted the richlink-darkmode branch December 1, 2023 11:41

JamieB-gu mentioned this pull request Dec 5, 2023

Darkmode - Liveblog rich links #9622

Closed

prout-bot added Overdue-on-PROD Overdue-on-CODE Seen-on-PROD and removed Overdue-on-PROD labels Dec 5, 2023

cemms1 removed the Overdue-on-CODE label Dec 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RichLink support darkmode #9683

RichLink support darkmode #9683

DanielCliftonGuardian commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

JamieB-gu left a comment

prout-bot commented Dec 5, 2023

RichLink support darkmode #9683

RichLink support darkmode #9683

Conversation

DanielCliftonGuardian commented Nov 28, 2023 • edited Loading

What does this change?

Why?

Screenshots

github-actions bot commented Nov 28, 2023 • edited Loading

JamieB-gu left a comment

Choose a reason for hiding this comment

prout-bot commented Dec 5, 2023

DanielCliftonGuardian commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading