Implement darkmode for article body links #9520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 699 kB ℹ️ View Unchanged
|
sophie-macmillan
force-pushed
the
sm-darkmode-links
branch
from
bd06c51 to
4e5ee6a
Compare
DanielCliftonGuardian
approved these changes
Nov 16, 2023
| import { decideLanguage, decideLanguageDirection } from '../lib/lang'; | ||
| import { revealStyles } from '../lib/revealStyles'; | ||
| import type { ImageForAppsLightbox } from '../model/appsLightboxImages'; | ||
| import { palette as themePalette } from '../palette'; |
There was a problem hiding this comment.
could keep this as palette
There was a problem hiding this comment.
Yeah we definitely could. I might leave it as is for now so its consistent with the other uses and then we can refactor once we've got rid of the decidePalette
There was a problem hiding this comment.
I’ve used schemedPalette as well 😆
mxdvl
reviewed
Nov 16, 2023
Comment on lines
+102
to
+103
| border-bottom: 1px solid | ||
| ${themePalette('--article-link-border-hover')}; |
There was a problem hiding this comment.
FYI, I’m proposing we move to text-decoration-color in Byline: #9494
I also wonder if we should simply use currentColor on hover? Is it ever a different colour to the anchor’s color?
sophie-macmillan
added a commit
that referenced
this pull request
Nov 16, 2023
This reverts commit 8bdfc10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the article links to use the palette. The current implementation of this in AR is a neutral link colour rather than the pillar colour
Why?
This is part of a larger body of work to support dark mode on apps.
Resolves #9497
Screenshots