-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark mode to standfirst 🌞 🌚 #9290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -16.1 kB (-1%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
mxdvl
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
(I only have two small, non-blocking comments)
abeddow91
force-pushed
the
ab/standfirst-darkmode
branch
from
October 24, 2023 13:31
3bf0276
to
8dfe4a2
Compare
cemms1
force-pushed
the
ab/standfirst-darkmode
branch
2 times, most recently
from
October 26, 2023 09:00
715d70b
to
40dd9c5
Compare
cemms1
force-pushed
the
ab/standfirst-darkmode
branch
from
October 30, 2023 09:41
40dd9c5
to
db2cb80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the standfirst component to use the new palette of light and dark mode styles
Why?
This is part of a wider body of work to add dark mode for apps articles.
Screenshots