feat: Add support for fixed/small/slow-IV container type #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +192 B (0%) Total Size: 1.63 MB
ℹ️ View Unchanged
|
AshCorr
force-pushed
the
ash/FixedSmallSlowIV.tsx
branch
3 times, most recently
from
f9a36e6 to
2d2bf57
Compare
AshCorr
force-pushed
the
ash/FixedSmallSlowIV.tsx
branch
from
2d2bf57 to
2ebcd02
Compare
AshCorr
changed the title
AshCorr
commented
Apr 28, 2022
| parameters: { | ||
| chromatic: { | ||
| viewports: [ | ||
| breakpoints.mobile, |
There was a problem hiding this comment.
If we're planning on adding all these breakpoints for every type of container we probably need to find a way to give chromatic some kind of focus so that it only checks files that could have changed.
This might be some help? https://www.chromatic.com/docs/turbosnap
There was a problem hiding this comment.
If we're planning on adding all these breakpoints for every type of container we probably need to find a way to give chromatic some kind of focus so that it only checks files that could have changed.
This might be some help? https://www.chromatic.com/docs/turbosnap
Interesting. It's hard to say if this is a good option for us or not, I think the write up at the link you gave (thanks) is fairly accurate in being hesitant but if this does work the way we want it to then it could be a big win
There was a problem hiding this comment.
Raised #4768 for this, tried to explain the incompatibility the way I understand it in this PR
AshCorr
requested review from
a team,
JamieB-gu,
marsavar and
iainjchambers-guardian
as code owners
oliverlloyd
reviewed
Apr 28, 2022
24 tasks
Co-authored-by: Oliver Lloyd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds the
fixed/small/slow-IVcontainer type!Why?
More fronts!
Screenshots