Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump web-vitals library with breaking CLS change #3074

Closed
wants to merge 1 commit into from

Conversation

gtrufitt
Copy link
Contributor

@gtrufitt gtrufitt commented Jun 3, 2021

What does this change?

Bump the web-vitals library which contains the new definition of CLS described in https://web.dev/evolving-cls/

In Google search tools, we see a reduction in CLS and increase in Good number of pages, we should see this reflected in our data.

Copy link
Contributor

@nitro-marky nitro-marky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

Size Change: +824 B (0%)

Total Size: 861 kB

Filename Size Change
dist/coreVitals.js 2.69 kB +180 B (6%) 🔍
dist/coreVitals.legacy.js 5.34 kB +176 B (3%)
dist/ga.js 2.87 kB +234 B (8%) 🔍
dist/ga.legacy.js 2.9 kB +234 B (8%) 🔍
ℹ️ View Unchanged
Filename Size Change
dist/945.js 21.5 kB 0 B
dist/945.legacy.js 21.6 kB 0 B
dist/atomIframe.js 776 B 0 B
dist/atomIframe.legacy.js 801 B 0 B
dist/braze-web-sdk-core.js 34.9 kB 0 B
dist/braze-web-sdk-core.legacy.js 35 kB 0 B
dist/dynamicImport.js 1.91 kB 0 B
dist/dynamicImport.legacy.js 1.97 kB 0 B
dist/EditionDropdown.js 696 B 0 B
dist/EditionDropdown.legacy.js 705 B 0 B
dist/elements-InteractiveBlockComponent.js 1.53 kB 0 B
dist/elements-InteractiveBlockComponent.legacy.js 1.58 kB 0 B
dist/elements-RichLinkComponent.js 3.18 kB 0 B
dist/elements-RichLinkComponent.legacy.js 3.23 kB 0 B
dist/elements-YoutubeBlockComponent.js 1.18 kB 0 B
dist/elements-YoutubeBlockComponent.legacy.js 1.24 kB 0 B
dist/embedIframe.js 780 B 0 B
dist/embedIframe.legacy.js 804 B 0 B
dist/frontend.server.js 276 kB 0 B
dist/GetMatchStats.js 3.31 kB 0 B
dist/GetMatchStats.legacy.js 3.37 kB 0 B
dist/guardian-braze-components.js 15.2 kB 0 B
dist/guardian-braze-components.legacy.js 15.3 kB 0 B
dist/MostViewedFooterData.js 6.31 kB 0 B
dist/MostViewedFooterData.legacy.js 6.4 kB 0 B
dist/MostViewedRightWrapper.js 5.6 kB 0 B
dist/MostViewedRightWrapper.legacy.js 5.85 kB 0 B
dist/newsletterEmbedIframe.js 740 B 0 B
dist/newsletterEmbedIframe.legacy.js 762 B 0 B
dist/OnwardsLower.js 11.1 kB 0 B
dist/OnwardsLower.legacy.js 11.4 kB 0 B
dist/OnwardsUpper.js 11.7 kB 0 B
dist/OnwardsUpper.legacy.js 12 kB 0 B
dist/ophan.js 6.18 kB 0 B
dist/ophan.legacy.js 6.17 kB 0 B
dist/react.js 146 kB 0 B
dist/react.legacy.js 153 kB 0 B
dist/sentry.js 678 B 0 B
dist/sentry.legacy.js 689 B 0 B
dist/sentryLoader.js 2.18 kB 0 B
dist/sentryLoader.legacy.js 4.8 kB 0 B
dist/shimport.js 2.75 kB 0 B
dist/shimport.legacy.js 2.76 kB 0 B
dist/SignInGateMain.js 1.85 kB 0 B
dist/SignInGateMain.legacy.js 1.88 kB 0 B

compressed-size-action

@mxdvl mxdvl mentioned this pull request Jul 20, 2021
@rcrphillips rcrphillips deleted the gtrufitt/bump-core-vitals branch August 13, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants