Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Portrait Immersive Main Media Width Problem #2205

Merged
merged 6 commits into from
Dec 8, 2020
Merged

The Portrait Immersive Main Media Width Problem #2205

merged 6 commits into from
Dec 8, 2020

Commits on Dec 7, 2020

  1. Don't choose immersive main media widths based on viewport

    @oliverlloyd
    oliverlloyd committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    8ea77fc View commit details
    Browse the repository at this point in the history

  2. Use orientation portrait and vh to work out width

    @oliverlloyd
    oliverlloyd committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    8c99690 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Update src/web/components/Img.tsx 

    Co-authored-by: Gareth Trufitt <[email protected]>
    @oliverlloyd @gtrufitt
    oliverlloyd and gtrufitt authored Dec 8, 2020
    Configuration menu
    Copy the full SHA
    6cf9201 View commit details
    Browse the repository at this point in the history

  2. Updated comment for 167vh approach

    @oliverlloyd
    oliverlloyd committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    6aaf1d5 View commit details
    Browse the repository at this point in the history

  3. Reduce Chromatic check threashold for these image stories

    @oliverlloyd
    oliverlloyd committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    28520b8 View commit details
    Browse the repository at this point in the history

  4. Increase threshold for these images

    @oliverlloyd
    oliverlloyd committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    e39fa8a View commit details
    Browse the repository at this point in the history