-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust carousel spacing to allow for media cards #12576
Conversation
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Size Change: +4 B (0%) Total Size: 905 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add the padding to the container div
rather than the carousel ol
?
The |
4c4dba2
to
3365ec9
Compare
Using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Seen on PROD (merged by @jamesmockett 8 minutes and 51 seconds ago) Please check your changes! |
What does this change?
Adds 8px of spacing to the top of the carousel between tablet and wide breakpoints
Why?
The top edge of the carousel is currently flush with the bottom of the navigation buttons. This isn't immediately apparent when the carousel is static or the cards have a transparent background, but it becomes obvious when the carousel is in motion (as the images and buttons touch) or a card has a solid background colour such as a media card.
Screenshots